From a059a6088673eed70c861c6deebc6587c2050a3a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Magnus=20Le=C3=9Fmann=20=28=40MarkL4YG=29?=
 <github@m-lessmann.de>
Date: Sat, 23 Nov 2024 13:20:14 +0100
Subject: [PATCH] chore: Kill genCert on error

- Because apparently it can run into an infinite loop when there are pKey issues
---
 .../certassist/openssl/OpenSSLCertificateCreator.java        | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/main/java/de/mlessmann/certassist/openssl/OpenSSLCertificateCreator.java b/src/main/java/de/mlessmann/certassist/openssl/OpenSSLCertificateCreator.java
index 5a994e2..74af6ab 100644
--- a/src/main/java/de/mlessmann/certassist/openssl/OpenSSLCertificateCreator.java
+++ b/src/main/java/de/mlessmann/certassist/openssl/OpenSSLCertificateCreator.java
@@ -393,8 +393,9 @@ public class OpenSSLCertificateCreator {
             throw new RuntimeException(e);
         }
 
+        StartedProcess certGenProc = null;
         try {
-            StartedProcess certGenProc = new ProcessExecutor()
+            certGenProc = new ProcessExecutor()
                 .command(
                     resolveOpenSSL(),
                     "x509",
@@ -421,6 +422,8 @@ public class OpenSSLCertificateCreator {
             throw new CommandLineOperationException("Failure running OpenSSL x509 command.", e);
         } catch (ExecutionException e) {
             throw new RuntimeException(e);
+        } finally {
+            killIfActive(certGenProc);
         }
         return outFile;
     }